B2B Provisioning: Add interstitial page to process redemption code retrieval #2422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Marking this as needs review - this works, and the tests pass so far (but the linting/formatting doesn't). So, it can be reviewed as-is. This will absolutely need some work to pull in the real API from the client when that's ready. |
gumaerc
force-pushed
the
jkachel/7954-add-b2b-code-redemption-interstitial
branch
from
72fce5a to
4973876
Compare
Merged
jonkafton
requested changes
Aug 15, 2025
Comment on lines
28
to
30
| if (isSuccess) { | ||
| redirect(urls.DASHBOARD_HOME) | ||
| } |
There was a problem hiding this comment.
The redirect should not happen during render. Fix e.g.
Suggested change
| if (isSuccess) { | |
| redirect(urls.DASHBOARD_HOME) | |
| } | |
| React.useEffect(() => { | |
| if (isSuccess) { | |
| redirect(urls.DASHBOARD_HOME) | |
| } | |
| }, [isSuccess]) |
| enrollment_code: code, | ||
| }) | ||
|
|
||
| React.useEffect(() => attach(), [attach]) |
There was a problem hiding this comment.
The function reference could change between renders because it comes from useMutation, so may run more than once.
We can give it an empty dependency array to just run once,
Suggested change
| React.useEffect(() => attach(), [attach]) | |
| React.useEffect(() => attach(), []) |
Though still not 100% guaranteed to run once. May not be a problem for a idempotent endpoint, but to guarantee it runs once we could track with a ref:
const hasRun = useRef(false)
React.useEffect(() => {
if (!hasRun.current) {
attach()
hasRun.current = true
}
}, [])
…ether a sample API hook The hook does hit the right endpoint but it's a stand-in until the API PR gets merged.
for more information, see https://pre-commit.ci
…titial page to use it and the nextjs redirect function instead of setting window.location directly
gumaerc
force-pushed
the
jkachel/7954-add-b2b-code-redemption-interstitial
branch
from
0e221b3 to
52cb1d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
Partially closes mitodl/hq#7954
Description (What does it do?)
Adds an interstitial page (and thus a URL) users can use to redeem an enrollment code to gain access to a B2B contract.
This uses the API that is added in mitodl/mitxonline#2866 - so this code is blocked until that PR is merged and the API client is updated and built.
But basically this allows us to have a URL that's
/attach/<code>which drops the user at a page that hits the redemption API, and then redirects them to the dashboard when it's done. There's some minimal text to explain what's going on but there's no other UI or processing.Screenshots (if appropriate):
How can this be tested?
docker compose exec web ./manage.py b2b_list contracts. Once you have the ID for the contract you made, list the codes for it. For example, assuming your ID is 30:docker compose exec web ./manage.py b2b_list contracts --codes 30[email protected]) in an incognito window/attach/the-code, replacingthe-codewith the code you got from the above commandAdditional context
This is mostly an MVP for this - it does the bare minimum. It would probably be good to make this a bit nicer - it'd be nice to display an alert on the dashboard to tell the user that they're now in a contract or something along those lines.